[cpp-ue4] Improved retry system to use Unreal's FHttpRetrySystem#9382
Merged
Conversation
… AsyncRetry method on the response and SetAutoRetryCount on the request"
Contributor
Author
|
Hello, I have not managed to produce updated cpp-ue4 samples using the script. I'd be happy to fix what is needed if someone can guide me. |
Member
|
Updated samples via 47693b8. |
Contributor
Author
|
@wing328 it seems like the failed check is about the contributing.md change? anything I should do? |
Member
|
Don't worry. I'll fix it after merging this PR to the master. Thanks for the PR as always. |
Member
|
Pushed 7703c92 with updated doc to the master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, I have improved the retry system of the generator as per Epic's suggestion. The new Http retry system allows timeouts and exponential backoff (technically unreal's implementation is arithmetic not exponential).
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master,5.1.x,6.0.x@ravinikam (2017/07) @stkrwork (2017/07) @etherealjoy (2018/02) @MartinDelille (2018/03) @muttleyxd (2019/08)